Skip to content
This repository has been archived by the owner on Mar 30, 2018. It is now read-only.

Commit

Permalink
make target required
Browse files Browse the repository at this point in the history
  • Loading branch information
sureshHARDIYA committed Nov 22, 2016
1 parent 4b9b96b commit bcb36d0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
* `Notify` component was not passing all the props.

### Breaking Changes
* `Modal` component needs to pass `target` as Element instead of Node
* `Modal` component needs to pass `target` as Element instead of Node. `target` is required.

### Coverage
* uikit-react has 100% test coverage now.
Expand Down
2 changes: 1 addition & 1 deletion src/Modal/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ import Prompt from './Prompt'
export default class Modal extends Component {

static propTypes = {
target: PropTypes.element.isRequired,
cancelLabel: PropTypes.string,
children: PropTypes.node,
confirmLabel: PropTypes.string,
isOpen: PropTypes.bool,
target: PropTypes.element,
type: PropTypes.string,
onCancel: PropTypes.func,
onConfirm: PropTypes.func,
Expand Down

0 comments on commit bcb36d0

Please sign in to comment.