Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD turbolinks support #24

Closed
wants to merge 1 commit into from
Closed

ADD turbolinks support #24

wants to merge 1 commit into from

Conversation

achmiral
Copy link
Contributor

  • Add turbolinks 5.2.0
  • Fix turbolinks browsersyc integration using snippetOptions
  • Change browsersync port to 8080
  • Update stilsa.js, scripts.js and custom.js
  • Add script tag for tubolinks on master layout
  • Generate new pages folder

@achmiral
ADD turbolinks support
d23c7d8 
- Add turbolinks 5.2.0
- Fix turbolinks browsersyc integration using snippetOptions
- Change browsersync port to 8080
- Update stilsa.js, scripts.js and custom.js
- Add script tag for tubolinks on master layout
- Generate new pages folder
@achmiral achmiral mentioned this pull request Feb 23, 2019
Closed
@nauvalazhar
Copy link
Member

Hi, thank you for your contribution. I'll try it first, but, please remove type="text/javascript" on your <script> tag.

Thank you

@nauvalazhar nauvalazhar self-requested a review February 23, 2019 04:41
@nauvalazhar
Copy link
Member

Also, place the <script> tag of Turbolink before the </ body> tag.

nauvalazhar
nauvalazhar requested changes Feb 23, 2019
View reviewed changes
Copy link
Member

@nauvalazhar nauvalazhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and it's cool. But, I will merge your request after the changes I mentioned before :)

@nauvalazhar
Copy link
Member

I found a bug; when you go to page "A" and go to page "B", then go to page "A" again, then the event that was initialized will be fire 2 times or more. This is because Turbolink initializes several times depending on the page visited.

@SunDi3yansyah
Copy link
Contributor

I found a bug; when you go to page "A" and go to page "B", then go to page "A" again, then the event that was initialized will be fire 2 times or more. This is because Turbolink initializes several times depending on the page visited.

seems to have to add something like this:

data-turbolinks-track="reload" data-turbolinks-eval="false"

in the script tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nauvalazhar nauvalazhar nauvalazhar requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@achmiral @nauvalazhar @SunDi3yansyah