OpenCV4 support #76
Merged
OpenCV4 support #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenCV4 support : change old C definition to standard c++ one in use the old definition still exist in imgproc.c_types.h
|
Fixes #62. |
|
OpenCV 4 from MacPorts depends on https://github.com/opencv/ade and causes a linking error to |
|
Let's wait a final 2.4 release before merging this, but it looks good! |
|
Yes at least no regression with opencv 3... |
|
I'll test on windows, but let's not block that |
jeremad
approved these changes
May 3, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenCV4 support : change old C definition to standard c++ one in use
the old definition still exist in imgproc.c_types.h
Summary
OpenCV 4 made some changes regarding C definition in imgproc
I update them. It seems to work....
Review
Should be compiled on Mac and Windows also.
I don't know if we need to check compatibility with OpenCV3
Test coverage