Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type regression using as and css on a Stitches component on Canary 7 #720

Closed
sandgraham opened this issue Aug 11, 2021 · 2 comments
Closed

Type regression using as and css on a Stitches component on Canary 7 #720

sandgraham opened this issue Aug 11, 2021 · 2 comments
Labels
fixed: pending release typescript TypeScript related

Comments

@sandgraham
Copy link

Bug report

Describe the bug

On latest canary, 1.0.0-canary.7, using as with css on a styled component causes a type error.

To Reproduce

Example:

<Box as="h1" css={{ fontFamily: "fantasy" }} /> // type error

Here are two sandboxes comparing type behavior:

1.0.0-canary.7
1.0.0-canary.6

Additional context

Seems to have started in 1.0.0-canary.7.
@sandgraham
Copy link
Author

Side note: I was already removing any usage of as from my project 😅.

@peduarte peduarte added the typescript TypeScript related label Aug 11, 2021
@sandgraham
Copy link
Author

Looks like was fixed in canary.9 (and is still fixed in 11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed: pending release typescript TypeScript related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathantneal @peduarte @sandgraham