Fix compounds and default variants in react #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f50a63d:
|
peduarte
pushed a commit
that referenced
this pull request
Feb 12, 2021
* beta * migrate types (#340) * Add scroll properties to themeMap * feat: do not add a prefix to supplied name in theme() * test: support --only file_includes_string * test: separate conditions, prefix, utils tests * fix: theme applies object * feat: config is passed to utils * style: strongly apply prettier on javascript and typescript files * style: strongly apply prettier on javascript and typescript files * fix: apply prop after other styles * update types (#341) * style: format core types file * fix: patch to prevent variants with same name as a css prop from erroring * fix: return forward_ref to support forwarding refs * fix: return forward_ref to support forwarding refs * Update react types (#342) * noice * More fixes * docs: share the wonderful story of getHashString * fix: apply fix to support variant names share with css props from core to react * feat: remove '-moz-initial' from global types * fix: support `@import` at-rule * fix: supports at-rule in component css * fix: do not throw for unknown properties * feat: directly reference component/themes by selector * tests: cleanup tests * Fix Stitches CSS (#343) * export all the types (#344) * fix: match core component properties to react, document className & query * docs: remove extra lines in component prop typing * feat: rename prop to * expose config and update utils (#345) * feat: add getCssString function to sheet * docs: Enhance typings for global and theme functions * docs: types for toString/getCssString * type token (#346) * Types fix util token type (#348) * fix util token type * fix util types * feat: react components & theme stringify as a selector * fix comounds (#350) * compound variants as array (#351) * 0.1.0-canary.0 Co-authored-by: Abdulhadi Hallak <hallak.aa@gmail.com> Co-authored-by: Pedro Duarte <contact@peduarte.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jonathantneal FYI