Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Slightly leaky abstraction -- figure out the best way to extend this #7

Closed
elijahbenizzy opened this issue May 12, 2021 · 1 comment
Labels
sf-concern Issue concerning internal SF things.

Comments

@elijahbenizzy
Copy link
Collaborator

This is for an extension of hamilton called hamiltime. Currently it's perfectly abstracted away except for this enum. Let's figure out how to make it a completely separate product.

PRIOR_RUN = 3 # This node's value sould be taken from a prior run. This is not used in a standard function graph, but it comes in handy for repeatedly running the same one.

Some ideas:

  1. Release hamilton with hamiltime
  2. Have this be an extensible class that hamiltime can overwrite
  3. Have the function_graph, not the node type know about the node sources
  4. ...
@elijahbenizzy
Copy link
Collaborator Author

We are moving repositories! Please see the new version of this issue at DAGWorks-Inc/hamilton#8. Also, please give us a star/update any of your internal links.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
sf-concern Issue concerning internal SF things.
Projects
None yet
Development

No branches or pull requests

2 participants