Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Some scaffolding #135

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Some scaffolding #135

wants to merge 2 commits into from

Conversation

elijahbenizzy
Copy link
Collaborator

[Short description explaining the high-level reason for the pull request]

Changes

Testing

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

@elijahbenizzy
Copy link
Collaborator Author

Another TODO -- support data quality for dataframes. Some ideas:

  1. Add a output argument to these, allowing us to extract an item in the dataframe, etc... E.G. anything sliceable
  2. output could also apply to a specific column in extract_columns
  3. Add a schema argument, allowing us to run on a dataframe (E.G. column -> type mapping). Note this is redundant with datatype as well...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant