Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

fixes inconsistent parameterize documentation to use correct helper f… #192

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

elijahbenizzy
Copy link
Collaborator

…unctions

[Short description explaining the high-level reason for the pull request]

Changes

Testing

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

@elijahbenizzy elijahbenizzy marked this pull request as ready for review September 2, 2022 22:00
1. A specific value
2. An specific upstream node.
1. A specified value
2. The value from a specified upstream node.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace upstream with source?

@skrawcz skrawcz merged commit a89ad3b into main Sep 2, 2022
@skrawcz skrawcz deleted the parameterized-docs-fix branch September 2, 2022 22:48
@skrawcz
Copy link
Collaborator

skrawcz commented Sep 2, 2022

Will merge this now -- and follow up with better docs. Since I think this gets most of it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants