Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Demonstrates duckdb adapters + data loaders #195

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Sep 13, 2022

[Short description explaining the high-level reason for the pull request]

Changes

  • Adds documentation on duckdb integration
  • Adds documentation on data-loaders as adaptable modules

Testing

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

@elijahbenizzy elijahbenizzy force-pushed the db-integrations branch 3 times, most recently from 12c12cc to afa3810 Compare September 15, 2022 03:50
@elijahbenizzy elijahbenizzy changed the title WIP Demonstrates duckdb adapters + data loaders Sep 18, 2022
@elijahbenizzy elijahbenizzy marked this pull request as ready for review September 22, 2022 17:11
@elijahbenizzy elijahbenizzy marked this pull request as draft September 22, 2022 17:12
examples/data_loaders/README.md Outdated Show resolved Hide resolved
examples/data_loaders/README.md Outdated Show resolved Hide resolved
examples/data_loaders/README.md Show resolved Hide resolved
examples/data_loaders/generate_test_data.py Outdated Show resolved Hide resolved
examples/data_loaders/generate_test_data.py Outdated Show resolved Hide resolved
examples/data_loaders/load_data_duckdb.py Show resolved Hide resolved
@elijahbenizzy elijahbenizzy force-pushed the db-integrations branch 3 times, most recently from 275cb54 to ba74364 Compare September 26, 2022 18:06
@elijahbenizzy elijahbenizzy marked this pull request as ready for review September 26, 2022 18:14
examples/data_loaders/README.md Outdated Show resolved Hide resolved
examples/data_loaders/README.md Outdated Show resolved Hide resolved
examples/data_loaders/README.md Outdated Show resolved Hide resolved
examples/data_loaders/generate_test_data.py Outdated Show resolved Hide resolved
examples/data_loaders/generate_test_data.py Outdated Show resolved Hide resolved
@elijahbenizzy elijahbenizzy force-pushed the db-integrations branch 2 times, most recently from 604763f to ab20a05 Compare September 27, 2022 20:30
We still want built-in adapters, but for now this will work.
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also should remove the database.duckdb file?

@elijahbenizzy
Copy link
Collaborator Author

also should remove the database.duckdb file?

Nope we deleted the generator so it has to be there. We load from it.

@elijahbenizzy elijahbenizzy merged commit 1d6ca2a into main Jan 24, 2023
@elijahbenizzy elijahbenizzy deleted the db-integrations branch January 24, 2023 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants