Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Tweaks warning message from pandas index check #213

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Oct 21, 2022

If using a dask dataframe or series the index type checker will not capture it because it only checks for pandas types. So adding note to ignore if using DASK.

We will have to figure out how to support this -- likely with a specific result builder for Dask that takes this into account, or something like that.

Changes

  • adds to warning message

Testing

  1. Works locally.

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

If using a dask dataframe or series the index type checker
will not capture it because it only checks for pandas types.
So adding note to ignore if using DASK.

We will have to figure out how to support this -- likely
with a specific result builder for Dask that takes this into
account, or something like that.
@skrawcz skrawcz merged commit 646c518 into main Oct 21, 2022
@skrawcz skrawcz deleted the tweak_warning branch October 21, 2022 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant