Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

dbt Hamilton example update requirements and readme #241

Merged

Conversation

datarshreya
Copy link
Contributor

@datarshreya datarshreya commented Dec 3, 2022

PR for issue #240

Changes

  1. Updated README.md in /examples/dbt/: Changed pip install - r requirements.txt to pip install -r requirements.txt
  2. Updated requirements.txt in /examples/dbt/: Changed dbt to dbt-core, added requirement for pandera

How I tested this

dbt run before and after

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy elijahbenizzy self-requested a review December 4, 2022 21:08
@elijahbenizzy
Copy link
Collaborator

LGTM, thanks!

@elijahbenizzy elijahbenizzy merged commit be0a11a into stitchfix:main Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants