This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Tweaks logging when concatenating Dataframes #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should push for a convention to help make it easy to debug those columns and find the code if there is an issue. I don't hard code the convention here because I don't want to preclude things. Otherwise an annoying warning is probably good for now -- and could be removed/moved to debug later.
skrawcz
force-pushed
the
tweak_df_concat_log
branch
from
f26eb3b
to
f136d3e
Compare
That way we know how to map an output back to the function. We decided this was a better approach for now. We don't want to lose the linkage between output and function, but for dataframe flattening, this is the best approach. It does mean that the columns cease being valid python identifiers, but that's fine because we're in build_result. If people complain we can figure out a way to change it. Upside is that we have less code to check/manage with this approach.
skrawcz
force-pushed
the
tweak_df_concat_log
branch
from
1e32e51
to
b02e1a4
Compare
elijahbenizzy
approved these changes
Feb 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should push for a convention to help make it easy to debug those columns and find the code if there is an issue. I don't hard code the convention here because I don't want to preclude things. Otherwise an annoying warning is probably good for now -- and could be removed/moved to debug later.
Changes
How I tested this
Notes
Checklist