Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added the last day of the year to merch calendars, retail and fiscal #21

Merged
merged 1 commit into from Dec 15, 2017
Merged

added the last day of the year to merch calendars, retail and fiscal #21

merged 1 commit into from Dec 15, 2017

Conversation

chylauSF
Copy link
Contributor

Problem:

Bad code design, we should be explicit in what Months and day both calendars are ending on.

Retail Calendar end in:

January 31st

Fiscal Calendar end in:

July 31st

Solution:

Turn this information into Constants

@coveralls
Copy link

coveralls commented Dec 14, 2017 •
edited

Coverage Status

Coverage increased (+0.003%) to 99.708% when pulling 640fb80 on calendar-constants-for-fiscal-cal into db124ba on master.

jonworek
jonworek approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@jonworek jonworek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chylauSF chylauSF merged commit 31758a4 into master Dec 15, 2017
@jbusser jbusser deleted the calendar-constants-for-fiscal-cal branch December 14, 2019 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonworek jonworek jonworek approved these changes

@davidamcclain davidamcclain Awaiting requested review from davidamcclain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chylauSF @coveralls @jonworek