Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use of unstable library feature 'process_set_argv0' #1

Closed
mmstick opened this issue Oct 20, 2020 · 4 comments
Closed

use of unstable library feature 'process_set_argv0' #1

mmstick opened this issue Oct 20, 2020 · 4 comments

Comments

@mmstick
Copy link

mmstick commented Oct 20, 2020

Any chance to support those of us building Rust applications for Linux distributions that haven't yet updated Rustc beyond 1.43.0 (Ubuntu)?

@ghost
Copy link

ghost commented Oct 21, 2020

Hmm, I wonder what would be the most idiomatic way to solve this problem.

What if we add Cargo feature named "1.45.0" that is enabled by default and includes APIs introduced in rust 1.45.0, i.e. the arg0 method?

@mmstick
Copy link
Author

mmstick commented Oct 21, 2020

#[cfg(version("1.45.0")] was merged back in April, but sadly it is still marked as an experimental feature, so that won't work.

Any means of compiling it for older Rust releases is fine with me.

@taiki-e
Copy link
Collaborator

taiki-e commented Jan 16, 2021

I think it difficult to support old compilers using ways like cfg(version) as CommandExt is not sealed.

@taiki-e
Copy link
Collaborator

taiki-e commented Mar 21, 2021

Closing -- ubuntu's rustc is now 1.47, and async-process supports that version.

@taiki-e taiki-e closed this as completed Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants