Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency to vulnerable version of growl #31

Closed
mgosui opened this issue Oct 23, 2017 · 3 comments
Closed

Dependency to vulnerable version of growl #31

mgosui opened this issue Oct 23, 2017 · 3 comments

Comments

@mgosui
Copy link

mgosui commented Oct 23, 2017

Currently jenkins-mocha depends on mocha ^3.0.0, which installs vulnerable version of growl (1.9.2).
https://github.com/stjohnjohnson/jenkins-mocha/blob/master/package.json#L29

Upgrading to mocha 4.0.0 or above should fix this, but I’m not sure whether simple upgrade won’t cause any problem.
mochajs/mocha@e39a867
@stjohnjohnson
Copy link
Owner

Nice. Okay, I'll give a PR to increase to v4.

stjohnjohnson added a commit that referenced this issue Oct 23, 2017
@stjohnjohnson
feat(#31): Upgrade NPM dependencies
d970f30 
BREAKING CHANGE

 - Upgrading major version of Mocha
stjohnjohnson added a commit that referenced this issue Oct 23, 2017
@stjohnjohnson
Merge pull request #32 from stjohnjohnson/UpgradeVersions
6e2b5e3 
feat(#31): Upgrade NPM dependencies
@stjohnjohnson
Copy link
Owner

+ jenkins-mocha@6.0.0

@mgosui
Copy link
Author

mgosui commented Oct 24, 2017

Thank you for quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stjohnjohnson @mgosui