feat: implement a new experimental concrete syntax tree type. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new concrete syntax tree type called `SyntaxTree` that is based on `rowan` for the underlying representation. The tree is constructed via an infallible `parse` method that always returns a `SyntaxTree` along with a list of parse errors. A `Parser` has also been added that takes WDL source and outputs a list of parser events that can be used to build a `SyntaxTree`. Currently only version statements are being parsed in the V1 grammar; more grammar will be incrementally introduced in the future. Additionally, new file-based tests have been added to the `wdl-grammar` crate; each test has a `source.wdl` input and a baseline CST and error list files to compare against. The baselines are easily updated by setting the `BLESS` environment variable and running the test. All of the above if feature-gated behind the `experimental` feature of `wdl-grammar`.
This commit fixes the description of open brace and close brace tokens now that they are no longer part of a `Display` implementation.
peterhuene
commented
May 14, 2024
peterhuene
commented
May 14, 2024
* Fix return type for `delimited` method. * Fix implementation of `recover` method. * Improve error messages slightly. * Add a `require_in` method that requires the next token be in a set.
a-frantz
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new concrete syntax tree type called
SyntaxTreethat is based onrowanfor the underlying representation.The tree is constructed via an infallible
parsemethod that always returns aSyntaxTreealong with a list of parse errors.A
Parserhas also been added that takes WDL source and outputs a list of parser events that can be used to build aSyntaxTree.Currently only version statements are being parsed in the V1 grammar; more grammar will be incrementally introduced in the future.
Additionally, new file-based tests have been added to the
wdl-grammarcrate; each test has asource.wdlinput and a baseline CST and error list files to compare against. The baselines are easily updated by setting theBLESSenvironment variable and running the test.All of the above if feature-gated behind the
experimentalfeature ofwdl-grammar.Before submitting this PR, please make sure:
CHANGELOG.md(see"keep a changelog" for more information).
good, articulated reason as to why there shouldn be more than one).