Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update react navbar #132

Merged
merged 14 commits into from
Apr 21, 2023
Merged

feat: update react navbar #132

merged 14 commits into from
Apr 21, 2023

Conversation

pshrest2
Copy link
Contributor

@pshrest2 pshrest2 commented Apr 19, 2023 •
edited
Loading

This PR updates the Navbar component in theme-react pacakge, and also updates the omnibar in stjude design docs

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-mushroom-06a211710-132.centralus.3.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-mushroom-06a211710-132.centralus.3.azurestaticapps.net

@pshrest2 pshrest2 requested a review from ajswis April 19, 2023 19:02
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-mushroom-06a211710-132.centralus.3.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-mushroom-06a211710-132.centralus.3.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-mushroom-06a211710-132.centralus.3.azurestaticapps.net

@pshrest2 pshrest2 self-assigned this Apr 20, 2023
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-mushroom-06a211710-132.centralus.3.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-mushroom-06a211710-132.centralus.3.azurestaticapps.net

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-mushroom-06a211710-132.centralus.3.azurestaticapps.net

wayne-w-cloud
wayne-w-cloud approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@wayne-w-cloud wayne-w-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-mushroom-06a211710-132.centralus.3.azurestaticapps.net

@pshrest2 pshrest2 merged commit 32d198e into main Apr 21, 2023
@pshrest2 pshrest2 deleted the feat/update-react-navbar branch April 21, 2023 16:16
acchiao pushed a commit that referenced this pull request Apr 21, 2023
@stjudecloud-cloudy
Merge pull request #132 from stjudecloud/feat/update-react-navbar
8933b2f 
feat: update react navbar 32d198e
ajswis added a commit that referenced this pull request Jun 29, 2023
@ajswis
Revert "Merge pull request #132 from stjudecloud/feat/update-react-na…
9f30eba 
…vbar"

This reverts commit 32d198e, reversing
changes made to 3e97895.
ajswis added a commit that referenced this pull request Jul 6, 2023
@ajswis
Feat/remove navbar updates (#144)
61bfb02 
* Revert "Merge pull request #138 from stjudecloud/chore/add-nav-links-config"

This reverts commit 7c8a75e, reversing
changes made to d2d0e89.

* Revert "Merge pull request #137 from stjudecloud/feat/collapse-nav-links"

This reverts commit d2d0e89, reversing
changes made to 1aea68f.

* Revert "Merge pull request #137 from stjudecloud/feat/collapse-nav-links"

This reverts commit d2d0e89, reversing
changes made to 1aea68f.

* Revert "Merge pull request #136 from stjudecloud/fix/navbar-updates"

This reverts commit 1aea68f, reversing
changes made to c168a5b.

* Revert "Merge pull request #132 from stjudecloud/feat/update-react-navbar"

This reverts commit 32d198e, reversing
changes made to 3e97895.

* Revert "Merge pull request #129 from stjudecloud/feat/redesign-navbar"

This reverts commit f3053e4, reversing
changes made to fbf9ea6.

* Commit package.lock

* Fix build differences after revert

* Bump package versions

* Remove Alert stories
acchiao pushed a commit that referenced this pull request Jul 6, 2023
@stjudecloud-cloudy
Feat/remove navbar updates (#144)
639f7b5 
* Revert "Merge pull request #138 from stjudecloud/chore/add-nav-links-config"

This reverts commit 7c8a75e, reversing
changes made to d2d0e89.

* Revert "Merge pull request #137 from stjudecloud/feat/collapse-nav-links"

This reverts commit d2d0e89, reversing
changes made to 1aea68f.

* Revert "Merge pull request #137 from stjudecloud/feat/collapse-nav-links"

This reverts commit d2d0e89, reversing
changes made to 1aea68f.

* Revert "Merge pull request #136 from stjudecloud/fix/navbar-updates"

This reverts commit 1aea68f, reversing
changes made to c168a5b.

* Revert "Merge pull request #132 from stjudecloud/feat/update-react-navbar"

This reverts commit 32d198e, reversing
changes made to 3e97895.

* Revert "Merge pull request #129 from stjudecloud/feat/redesign-navbar"

This reverts commit f3053e4, reversing
changes made to fbf9ea6.

* Commit package.lock

* Fix build differences after revert

* Bump package versions

* Remove Alert stories 61bfb02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajswis ajswis ajswis approved these changes

@wayne-w-cloud wayne-w-cloud wayne-w-cloud approved these changes

@jamesmadson jamesmadson Awaiting requested review from jamesmadson

Assignees

@pshrest2 pshrest2

Labels
@stjudecloud/design.stjude.cloud @stjudecloud/ui-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pshrest2 @ajswis @wayne-w-cloud