Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Additional tests #105

Merged
merged 23 commits into from
Jun 12, 2024
Merged

tests: Additional tests #105

merged 23 commits into from
Jun 12, 2024

Conversation

adthrasher
Copy link
Member

Adding more in-depth checks of file contents, particularly for BAM and FASTQ format output.

@a-frantz a-frantz marked this pull request as ready for review June 11, 2024 15:00
@a-frantz a-frantz self-requested a review June 11, 2024 15:01
tests/tools/test_samtools.py Outdated Show resolved Hide resolved
tools/samtools.wdl Outdated Show resolved Hide resolved
@a-frantz a-frantz changed the title [WIP] Additional tests tests: Additional tests Jun 11, 2024
@a-frantz
Copy link
Member

@adthrasher the rollback did not fix the CI unfortunately

Copy link
Member

@a-frantz a-frantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @adthrasher ! I'll let you merge. We've still got more tests to add, but I think iteratively merging bits when we have bandwidth is going to be better than waiting for all our desired testing to happen at once.

@adthrasher adthrasher merged commit 84bd237 into main Jun 12, 2024
32 of 33 checks passed
@adthrasher adthrasher deleted the addl_tests branch June 12, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants