Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-of-line comment formatting breaks YAML #298

Closed
asger-noer opened this issue Nov 15, 2021 · 3 comments
Closed

End-of-line comment formatting breaks YAML #298

asger-noer opened this issue Nov 15, 2021 · 3 comments

Comments

@asger-noer
Copy link

I'm experiencing issues when trying to format comments inside yaml. It seems like Rewrap is considering the whole dict as a comment in some cases. I've attached some screenshots showing the issue.

Before running alt + Q

Working yaml

After running `alt + Q

Broken yaml
`

@stkb
Copy link
Owner

stkb commented Nov 15, 2021

Thanks for reporting; Yaml still need some work. It's on my list of things to do but it's a long list.

However it looks here like you're trying to format end-of-line comments? Those aren't supported yet either

@asger-noer
Copy link
Author

asger-noer commented Nov 24, 2021

I've tested some more and it actually seems to work better now with the block comments. End-of-line comments still doesn't work as you also mentioned.

@asger-noer asger-noer changed the title Incorrect YAML comment formatting End-of-line YAML comment formatting breaks Nov 24, 2021
@asger-noer asger-noer changed the title End-of-line YAML comment formatting breaks End-of-line comment formatting breaks YAML Nov 24, 2021
@stkb
Copy link
Owner

stkb commented Nov 29, 2021

Ok thanks, I'm going to close this as end-of-line comments are tracked in #46

@stkb stkb closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants