Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct annotations for signals in QThread and QNetworkAccessManager #129

Merged
merged 2 commits into from Feb 16, 2021
Merged

Correct annotations for signals in QThread and QNetworkAccessManager #129

merged 2 commits into from Feb 16, 2021

Conversation

TilmanK
Copy link
Contributor

@TilmanK TilmanK commented Jan 6, 2021

No description provided.

BryceBeagle
BryceBeagle requested changes Jan 6, 2021
View reviewed changes
Copy link
Collaborator

@BryceBeagle BryceBeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an entry to https://github.com/stlehmann/PyQt5-stubs/blob/b8e0a2b482de03a97b74af33006ffa13e13965de/CHANGELOG.md as well?

PyQt5-stubs/QtNetwork.pyi Outdated Show resolved Hide resolved
BryceBeagle
BryceBeagle approved these changes Jan 7, 2021
View reviewed changes
Copy link
Collaborator

@BryceBeagle BryceBeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR looks good, however you may want to check your git config to make sure you're committing with the credentials that GitHub expects

@TilmanK
Copy link
Contributor Author

TilmanK commented Jan 21, 2021

Hey, is there anything else you need for this PR? You'll squash it anyway, so the credentials won't matter, right?

@altendky
Copy link
Collaborator

@TilmanK, I personally prefer to do a regular merge generally. If you would prefer a squash to get rid of the commit name/email, we can.

@altendky altendky merged commit d48c930 into python-qt-tools:master Feb 16, 2021
@TilmanK
Copy link
Contributor Author

TilmanK commented Feb 16, 2021

Ah, sorry! I totally forgot that I wanted to rebase the commits. Anyway, next time then...
Thanks for accepting the PR.

bluebird75 pushed a commit to bluebird75/PyQt5-stubs that referenced this pull request Aug 24, 2021
@altendky
Merge pull request python-qt-tools#129 from TilmanK/master
ca4ea71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BryceBeagle BryceBeagle BryceBeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TilmanK @altendky @BryceBeagle