Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Updated documentation on target resetting #1107

Merged
merged 1 commit into from Mar 20, 2021
Merged

[doc] Updated documentation on target resetting #1107

merged 1 commit into from Mar 20, 2021

Conversation

Ant-ON
Copy link
Collaborator

@Ant-ON Ant-ON commented Mar 17, 2021 •
edited by Nightwalker-87

Updated a target resetting documentation. Related with #220, #1012

(Closes #261, Closes #533)

@Nightwalker-87 Nightwalker-87 self-requested a review March 17, 2021 18:08
@Nightwalker-87 Nightwalker-87 added this to In progress in Release v1.7.0 via automation Mar 17, 2021
@Nightwalker-87 Nightwalker-87 added this to the v1.6.2 milestone Mar 17, 2021
Release v1.7.0 automation moved this from In progress to Reviewer approved Mar 17, 2021
@Nightwalker-87
Copy link
Member

@Ant-ON: Sorry for asking, but can you rebase this PR to an earlier commit without closing it?
I'm currently trying to fix the Travis CI build issue we're facing currently.
This would allow for e.g. a force push without killing the base of this PR.

@Ant-ON
Copy link
Collaborator Author

Ant-ON commented Mar 18, 2021

@Nightwalker-87 I cannot do rebase, I can merge changes from develop.

@Nightwalker-87
Copy link
Member

OK, wait - that will not help to preserve consistency in history for this PR.
I'll have a look this evening. Following git documentation, it should be possible to rebase to the current develop.

@Ant-ON
Copy link
Collaborator Author

Ant-ON commented Mar 19, 2021

@Nightwalker-87 I rebase this PR to develop

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Mar 19, 2021 •
edited

Great, thx!

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Mar 20, 2021 •
edited

@Ant-ON Are there any tickets of which one can assume that they are resolved with this PR?
(Though this is only an update for the documentation.)

@Nightwalker-87 Nightwalker-87 changed the title Updated a target resetting documentation [doc] Updated documentation on target resetting Mar 20, 2021
@Ant-ON Ant-ON mentioned this pull request Mar 20, 2021
Closed
@Nightwalker-87 Nightwalker-87 merged commit 40e9aa2 into stlink-org:develop Mar 20, 2021
Release v1.7.0 automation moved this from Reviewer approved to Done Mar 20, 2021
@Nightwalker-87 Nightwalker-87 linked an issue Mar 20, 2021 that may be closed by this pull request
[reset] st-flash reset can be a hardware reset? #533
Closed
6 tasks
@Nightwalker-87 Nightwalker-87 mentioned this pull request Mar 20, 2021
Closed
6 tasks
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Mar 24, 2021
@Ant-ON Ant-ON deleted the add_reset_doc branch May 25, 2021 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nightwalker-87 Nightwalker-87 Nightwalker-87 approved these changes

Assignees

@Ant-ON Ant-ON

Labels
component/st-flash general/documentation status/resolved
Projects
No open projects
Release v1.7.0
  
Done
Release v1.7.0
Status: Done
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

[reset] st-flash reset can be a hardware reset? [reset] STM32F030: --reset option is not working
2 participants
@Ant-ON @Nightwalker-87