Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Fixed broken links #1312

Merged
merged 2 commits into from May 7, 2023
Merged

[doc] Fixed broken links #1312

merged 2 commits into from May 7, 2023

Conversation

gemesa
Copy link
Contributor

@gemesa gemesa commented May 5, 2023

Found some broken links while reading the docs and fixed them.

@slyshykO
Copy link
Collaborator

slyshykO commented May 5, 2023

@Nightwalker-87
I think that supported devices.md should be renamed to supported_devices.md
Names with spaces still add more issues than they should.

@gemesa
Copy link
Contributor Author

gemesa commented May 5, 2023

Right, if you rename it you can remove the angle brackets also:
[supported devices.md](<doc/supported devices.md>) --> [supported_devices.md](doc/supported_devices.md)

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented May 5, 2023 •
edited

Right, if you rename it you can remove the angle brackets also: [supported devices.md](<doc/supported devices.md>) --> [supported_devices.md](doc/supported_devices.md)

@gemesa Yes, we should do that. Can you update this PR directly?

@Nightwalker-87 Nightwalker-87 self-requested a review May 5, 2023 19:59
@Nightwalker-87 Nightwalker-87 added this to In progress in Release v1.8.0 via automation May 5, 2023
@Nightwalker-87 Nightwalker-87 added this to the v1.8.0 milestone May 5, 2023
@Nightwalker-87 Nightwalker-87 changed the title Fixed broken links [doc] Fixed broken links May 5, 2023
@Nightwalker-87 Nightwalker-87 moved this from In progress to Review in progress in Release v1.8.0 May 5, 2023
@gemesa
Copy link
Contributor Author

gemesa commented May 7, 2023

Right, if you rename it you can remove the angle brackets also: [supported devices.md](<doc/supported devices.md>) --> [supported_devices.md](doc/supported_devices.md)

@gemesa Yes, we should do that. Can you update this PR directly?

Renamed it, please review it

Release v1.8.0 automation moved this from Review in progress to Reviewer approved May 7, 2023
@Nightwalker-87 Nightwalker-87 merged commit a9c2139 into stlink-org:develop May 7, 2023
10 checks passed
Release v1.8.0 automation moved this from Reviewer approved to Done May 7, 2023
@stlink-org stlink-org locked as resolved and limited conversation to collaborators May 7, 2023
@gemesa gemesa deleted the fix-broken-links branch May 7, 2023 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nightwalker-87 Nightwalker-87 Nightwalker-87 approved these changes

Assignees

@gemesa gemesa

Labels
bug/fixed general/documentation status/resolved
Projects
No open projects
Release v1.8.0
Done
Release v1.8.0
Status: Done
Milestone
v1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gemesa @slyshykO @Nightwalker-87