Fixed st-info --probe mechanism #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ease v1/v2/v2.1/v3 identification and supported devices filtering
actually open all counted devices - the two vid check need to be aligned. also now display if some st device has been skipped.
…one_ probe failed. we return count and list of successfully probed devices, no need to free everything if some libusb call of the last probe attempt failed.
…not number of probed devices.
…cted. serial match was not done for v1 device, resulting in attempting to open it systematically, leading to some libusb device claim call failure. Lookup device serial for all chips, compare it if needed, and continue.
|
This should help #679. |
Nightwalker-87
approved these changes
Apr 10, 2020
|
Thank you very much for fixing this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
here's a small patchset to fixup st-info probe mecanism and lower layers.
This has been tested with a couple of devices connected (v1, v2, v2.1 and v3). Note that it seems that all v1 have the same serial, so, i guess that selecting them will be complicated - there's apparently some kind of hidden env variable filter mecanism based on usb addr in addition to the --serial parameter, but i've not tested it.