handle probed stlink with unconnected target properly #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grevaillot
force-pushed
the
to_merge/probe_unconnected_target
branch
from
e77d561
to
e90f809
Compare
do not abort in case of load device param "error" : this is supposed to return -1 if device is "unknown" or not detected, which is not reaaally an error. we want probe to tell us what is the connected device even if we can not operate it we want probe to tell us that it can not operate it, not to hide the connected stlink
check flash type before attempting to continue flash operations
Check if connected target chip id is known. Some more info regarding connected chip should be set in chipid to know if debugging / attach is possible, but not yet. some more checks should be done to generate flash map / handle flashing if flash type is not supported..
grevaillot
force-pushed
the
to_merge/probe_unconnected_target
branch
from
e90f809
to
8f778b2
Compare
Nightwalker-87
approved these changes
Apr 20, 2020
|
@grevaillot: Thx for addressing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stlink_open_usb now returns without failure when no target is detected, or when target is not fully handled. Fix behaviour of tools in that case.
nb: st-util handling should maybe be discussed. currently it allows to start with no supported flash, which is what i would expected from a debugging tool, but flashing wont work obvs.
refs #432