Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isn't $(prefix)/include/stm32.h too generic? #976

Closed
blacklion opened this issue Jun 3, 2020 · 2 comments
Closed

Isn't $(prefix)/include/stm32.h too generic? #976

blacklion opened this issue Jun 3, 2020 · 2 comments

Comments

@blacklion
Copy link

I'm not sure, is it bug or "as intended" but previous versions of stlink (1.6.0 and earlier) installed main include/stlink.h and several other headers under include/stlink/.
1.6.1 installs include/stlink.h, include/stm32.h and several other headers under include/stlink/.
Is it as intended? stm32.h looks too generic to be installed into system-wide include directory, isn't it?

@Nightwalker-87
Copy link
Member

Nightwalker-87 commented Jun 3, 2020

These project paths are still subject to change because of ongoing work. We had to find an interim solution for the recent Release v1.6.1, because we could not restructure the project all at once. Please give us some time to address this along with general improvements.

@Nightwalker-87 Nightwalker-87 self-assigned this Jun 3, 2020
@Nightwalker-87 Nightwalker-87 added this to the v1.6.2 milestone Jun 3, 2020
@Nightwalker-87 Nightwalker-87 added this to To do in Release v1.7.0 via automation Jun 3, 2020
Nightwalker-87 added a commit that referenced this issue Jun 4, 2020
@Nightwalker-87
Copy link
Member

I've reorganised some project source & header directories now.
However we still have stm32.h installed to /usr/local/include/ as it is solely linked to stlink.h.
Related to #903 I expect further changes around here. Looking at this, it should be ok for now.

@Nightwalker-87 Nightwalker-87 moved this from To do to Review in progress in Release v1.7.0 Jun 4, 2020
Nightwalker-87 added a commit that referenced this issue Jun 4, 2020
Nightwalker-87 added a commit that referenced this issue Jun 4, 2020
Nightwalker-87 added a commit that referenced this issue Jun 4, 2020
@Nightwalker-87 Nightwalker-87 moved this from Review in progress to Reviewer approved in Release v1.7.0 Jun 13, 2020
Release v1.7.0 automation moved this from Reviewer approved to Done Jun 14, 2020
@stlink-org stlink-org locked as resolved and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants