-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not generate .deps on clean #279
Conversation
Makefile
Outdated
@@ -100,4 +100,6 @@ clean: clean-rs clean-patch clean-html | |||
@mkdir -p .deps | |||
python3 scripts/makedeps.py $< > $@ | |||
|
|||
-include $(patsubst devices/%.yaml, .deps/%.d, $(YAMLS)) | |||
$(PATCHED_SVDS): $(patsubst devices/%.yaml, .deps/%.d, $(YAMLS)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we stick the .deps/%.d
dependency on L37 with svd/%.svd.patched
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this way make treats dep files as intermediate and removes them after build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick test and that seems to work great, ensuring each SVD only depends on its own .d
file too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're right about the intermediate business. Maybe stick them in .PRECIOUS too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
Thanks! Could you rebase off master, as it now contains |
Incidentally I think you could do |
94a455a
to
718baed
Compare
Yeah, I see. Didn't know about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
bors r+
bors r=adamgreig |
🔒 Permission denied Existing reviewers: click here to make Disasm a reviewer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded |
No description provided.