Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating STM32H7 ETH_MAC MMC mask register writable #658

Merged
merged 2 commits into from Nov 10, 2021
Merged

Updating STM32H7 ETH_MAC MMC mask register writable #658

merged 2 commits into from Nov 10, 2021

Conversation

ryan-summers
Copy link
Member

@ryan-summers ryan-summers commented Nov 10, 2021 •
edited

This PR fixes #656 by making the MMC_TX/RX_INTERRUPT_MASK register completely writable.

TODO:

  • Verify these bits can be written in hardware

@github-actions
Copy link

Memory map comparison

@ryan-summers ryan-summers marked this pull request as ready for review November 10, 2021 11:14
@newAM newAM added the stm32h7 label Nov 10, 2021
@stm32-rs stm32-rs deleted a comment from bors bot Nov 10, 2021
richardeoin
richardeoin approved these changes Nov 10, 2021
View reviewed changes
Copy link
Member

@richardeoin richardeoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

bors r+

richardeoin added a commit to maximeborges/stm32-rs that referenced this pull request Nov 10, 2021
@richardeoin
ETH_MAC MMC register patch stm32-rs#658 also applies to MP1
f76fd39
@bors
Copy link
Contributor

bors bot commented Nov 10, 2021

Build succeeded:

@bors bors bot merged commit 214f440 into stm32-rs:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardeoin richardeoin richardeoin approved these changes

Assignees
No one assigned
Labels
stm32h7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

STM32H7 series MMC registers have a mislabeled interrupt mask bit
3 participants
@ryan-summers @richardeoin @newAM