stm32f411 otg fixes #697
Merged
stm32f411 otg fixes #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@burrbull do you have some time for a review :)? |
I don't have write access to this repo. Ask @adamgreig |
|
oh. sorry. yea, @adamgreig, do you have some spare time for this? |
|
@adamgreig or @newAM, could you please review this? |
newAM
approved these changes
Apr 24, 2022
There was a problem hiding this comment.
I double checked the changes against RM0383 Rev 3, looks good to me, thanks for the fixes!
I do have write access to the repo, but I was given write access for STM32WL pull-requests, I'll ask @adamgreig about merging PRs for other chips.
|
bors r+ |
|
Build succeeded: |
|
thanks @newAM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, these are some issues I noticed when I was developing my usb host crate for the stm32f411.