Fix ADC disable #699
Merged
Fix ADC disable #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ADDIS`, as `ADEN` is a signal to the ADC peripheral to change it's state. Both signals have to be "1" to change the state. In case of `ADDIS` it will be only reset to "0", after the state has successfully changed. The procedure of disabling is the same between `stm32f303xc` (RM0316 15.3.10), where I've noticed the bug, and `stm32h7x3` (RM0443 25.4.9), for which this code was initially committed, so I assume this affects every device using the `adc_v3.yaml`.
|
This is an error in the enumerations, thanks for highlighting it. We actually have better enumerations for these bits in |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADDIS, asADEN, is a signal to the ADC peripheral to change it'sstate. Both signals have to be "1" to change the state.
In case of
ADDISit will be only reset to "0", after the state hassuccessfully changed.
The procedure of disabling is the same between
stm32f303xc(RM031615.3.10), where I've noticed the bug, and
stm32h7x3(RM0443 25.4.9),for which this code was initially committed, so I assume this affects
every device using the
adc_v3.yaml.