Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use consistent ubuntu version #792

Merged
merged 2 commits into from Jan 4, 2023
Merged

ci: use consistent ubuntu version #792

merged 2 commits into from Jan 4, 2023

Conversation

newAM
Copy link
Member

@newAM newAM commented Dec 27, 2022

Nightlies are failing due to a libc version mismatch: https://github.com/stm32-rs/stm32-rs/actions/runs/3788639981/jobs/6441622524

The ci workflow is being run with ubuntu-latest (22.04), and the rest with the older ubuntu-20.04, which is a likely source for nightlies failing while the main CI workflow runs. Not sure if this will fix it, but it is a good first start.

@github-actions
Copy link

Memory map comparison

@newAM
Copy link
Member Author

newAM commented Dec 27, 2022

On a related topic, is there a reason that only the gh-pages CI file uses svd and everything else in CI uses svdtools? (@burrbull ?) The HTML build is failing from the STM32L4+ PR with an error that only shows when using svd.

@burrbull

This comment was marked as resolved.

@github-actions
Copy link

Memory map comparison

@adamgreig
Copy link
Member

On a related topic, is there a reason that only the gh-pages CI file uses svd and everything else in CI uses svdtools? (@burrbull ?) The HTML build is failing from the STM32L4+ PR with an error that only shows when using svd.

I think it was just missed when the rest were swapped to svdtools in #701, I don't see why we couldn't swap it. Wanna do that in this PR?

@newAM
Copy link
Member Author

newAM commented Jan 4, 2023

Wanna do that in this PR?

Sure! Done.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Memory map comparison

Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 4, 2023

Build succeeded:

@bors bors bot merged commit 057b2e1 into stm32-rs:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants