Continue Improvements to PWM Interface #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
reviewed
Aug 20, 2023
therealprof
reviewed
Aug 20, 2023
|
Would you please rebase the PR to get rid of the merge (and maybe some of the intermediate sausage making)? |
AdinAck
force-pushed
the
master
branch
2 times, most recently
from
7755c13
to
5ef7017
Compare
- dead time - fix typo - update changelog
|
#170 will fix this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that the interface to create complementary PWM channels is exposed, it should include controlling the dead time as well.
Change(s) Description
set_dead_timefunction to complementary channels, provided by theComplementaryPwmtraitTesting
It works.
Limitations
The implementation I've made for now does not include any of the fancy multiplier capabilities the BDTR register provides. This only allows the dead time to be from 0-7 clock cycles.
Future