Add unidirectional SPI DMA #104
Merged
+144
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase on master and use AsSlice instead of AsRef? |
|
Oops, I guess I forgot to compile after rebasing yesterday 😅 |
That took a bit longer than a day, but I have finally got around to testing it. Looks like it works which means that this should be ready to merge unless there are any other issues |
therealprof
reviewed
Oct 27, 2019
src/spi.rs
Outdated
Comment on lines
230
to
233
|
|
||
|
|
||
|
|
||
|
|
therealprof
reviewed
Oct 27, 2019
src/spi.rs
Outdated
Comment on lines
247
to
249
| use core::sync::atomic::{self, Ordering}; | ||
|
|
||
| use as_slice::AsSlice; |
There was a problem hiding this comment.
nit: please move module-wide imports to the top
|
@TheZoq2 Mind rebasing? Otherwise looks good to go for me. |
|
Sure, thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for transmitting data over SPI using DMA.
Since this is a basic implementation, only non-circular buffers are supported. However, at the moment I don't have a need for that, and I think we might have to restructure some DMA stuff for simultaneous TX and RX support so I don't want to put too much effort into this until we get around to that.
I think RX support might be fairly easy, but it would require reconfiguring the SPI device as reads happen on writes in bidirectional mode.
Note: I have yet to test DMA over SPI2, I'll do that tomorrow but the code probably shouldn't change