Add configuration options to QEI interface #178
Conversation
There was a problem hiding this comment.
Thanks for the PR, looks good to me.
I'm unsure of the names for everything added. They're taken almost verbatim from the datasheet, but aren't very descriptive or intuitive. Should we bikeshed this or leave it as is for now?
I think the names are fine, but the comments could use being a bit more descriptive
| use cortex_m_rt::entry; | ||
| use stm32f1xx_hal::{delay::Delay, pac, prelude::*, qei::QeiOptions, timer::Timer}; |
There was a problem hiding this comment.
I prefer the expanded version that was removed
There was a problem hiding this comment.
This was rustfmt. Should I change it or leave it as is?
|
I prefer the rustfmt'ed version unless we establish a custom style. I'll think we'll take it as is, thanks! |
|
@jamwaffles Oh, and of course I forgot to check and complain about the missing note in CHANGELOG.md again. Mind following up? |
This PR adds the
QeiOptionsstruct which allows configuration of the timer slave mode (affecting QEI) and the QEI auto reload register value. There's also some minor formatting noise so apologies for that.I've tested this on a Blue Pill with a CNC jog pendant that produces 400 PPR. Seems to work well.
I'm unsure of the names for everything added. They're taken almost verbatim from the datasheet, but aren't very descriptive or intuitive. Should we bikeshed this or leave it as is for now?