Rework examples to apply to more targets and test in CI #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
force-pushed
the
improve-examples-ci
branch
from
ee21229
to
d8a5a55
Compare
This also improves the required-features selection for the examples. Signed-off-by: Daniel Egger <daniel@eggers-club.de>
therealprof
force-pushed
the
improve-examples-ci
branch
from
d8a5a55
to
d2cfcc9
Compare
|
r? @TheZoq2 |
|
We should fix this. |
We could, however there's very little benefit for small teams and even worse it has it's own set of funny issues. |
|
Sorry for the delay! Looks like some good changes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also improves the required-features selection for the examples.
Signed-off-by: Daniel Egger daniel@eggers-club.de