Added support for continuous and discontinuous scan mode #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR and sorry to keep you waiting for so long for the review! The changes look good to me, would you mind adding a changelog entry? Also, cc @yjh0502 since you were the author of the other linked PR, do you have any opinion on this? Does it suit your use case? |
katyo
force-pushed
the
adc-scan-continuous
branch
from
7c3d9aa
to
f387c33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for continuous scan mode (solves issue #212).
Also adds support for discontinuous conversion.
Different approach than #214. This PR does not break existing API.