Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aliases for serial tx/rx #59

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Conversation

burrbull
Copy link
Contributor

No description provided.

@therealprof
Copy link
Member

@TheZoq2 What do you think about this change? I don't have any particular opinion here.

@TheZoq2
Copy link
Member

TheZoq2 commented Jun 2, 2019

I don't really have any strong opinion either.

If i'm reading this right, this would be a breaking change, right? Then maybe it makes sense to wait with merging it until we have a few more breaking changes. That way we have the option of doing a minor release or two in between

@burrbull
Copy link
Contributor Author

burrbull commented Jun 2, 2019

This change is not breaking. Only shortcuts for type names to simplify their use in statics.

@TheZoq2
Copy link
Member

TheZoq2 commented Jun 3, 2019

Oh, I missread it then, in that case, i'd be happy to merge it if you add a changelog entry :)

@TheZoq2 TheZoq2 merged commit 5ad17fc into stm32-rs:master Jun 3, 2019
@burrbull burrbull deleted the serial-aliases branch June 3, 2019 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants