Add more configuration options to UART #63
Conversation
examples/serial_config.rs
Outdated
|
|
||
| let sent = b'U'; | ||
| block!(tx.write(sent)).ok(); | ||
| // block!(timer.wait()); |
There was a problem hiding this comment.
What's the purpose of these commented out lines?
There was a problem hiding this comment.
Also if we're not going to use the timer, why initialise it?
There was a problem hiding this comment.
Good catch, I'll remove the comments and timer
src/serial.rs
Outdated
|
|
||
| impl Default for Config { | ||
| fn default() -> Config { | ||
| let baudrate = 19_200_u32.bps(); |
There was a problem hiding this comment.
19200 baud is kind of an odd choice, I haven't seen that in common use since the age of the acoustic coupler. Maybe either use 9600 or 115200 baud instead which are the two common default baud rates used nowadays (with a slight preference for the latter).
There was a problem hiding this comment.
You're absolutely right, I have no idea what made me chose 19200. 115200 makes sense to me.
|
I implemented the changes you suggested, does everything look OK now? Also, the changelog is starting to get big, perhaps we should do a release soon. Though maybe we should fix all the deprecation warnings introduced by |
|
Release sounds good to me. Not sure we really want to deal with the fall out and actually how to deal with it. I tried changing the |
|
Yea, that change seems strange to me, especially since it's a minor change. It was very strange to do a cargo clean and discover hundreds of warnings. I tried updating it by just adding I'll do a release with what we have for now, then we can figure out what to do about this later Edit: I guess you beat me to doing a release 👍 |
|
Looks like you forgot to bump the the version in the README, should we push a 0.3.1 to fix that or just leave it? @therealprof |
|
Huh, I did? Shouldn't matter too much. |
This PR adds the the ability to configure the stop bits and parity bits of the serial device. It is inspired by the implementation in the f4 hal but it does differ a bit from that.
The main difference is that this implementation doesn't allow you to specify word length which I did for 2 reasons:
The second point means that a device configured to send 9 bit words with one parity bit actually sends 8 bit words and the parity bit. This seems to go against the way UART protocols are usually defined. To avoid that confusion, I decided to just disable the option of changing word size and assume the user wants to send 8 bits of actual data.
Another difference to the f4 impl is that I don't use a separate config submodule. To me, that feels unnecessary, but feel free to convince me otherwise.
Finally, this works until we add support for USART5 and 6 which don't allow 1.5 and 0.5 stop bits. Should we future proof this design for that?