-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented InputPin trait for output pins #105
Conversation
+1. I also need this functionality, to implement a weird "bidirectional" SPI for ST7735 TFT. And it is already implemented in the "brother" crate stm32f4xx-hal (https://github.com/stm32-rs/stm32f4xx-hal/blob/b6f010538a4f86db207b23440d3053339ce08397/src/gpio.rs#L179). |
Status? This is the sort of functionality that is required to support a relatively-common protocol, and ommitting it fragments the ecosystem with people using forks etc instead of |
Sorry for the long delay. I'll hope to catch up again in the next days :) What about this concern: #84 (comment)? I havn't thought it through myself. Implementing for |
Please run rustfmt on the code again. It's currently complaining about one superfluous newline. This is what makes the Travis jobs fail. |
I also noticed that since the GPIO refactoring to use variants was merged, this should also be adapted in this PR. I've quickly done this myself, hope you don't mind me going off your changes @David-OConnor. I had to create a new PR since I cannot just push to a branch in your repo: #114. Would be cool if you could check it out and report if it works for your use-case. You'll notice that I restricted the |
Closed in favor of #114. |
This enables things like OneWire. Equiv of this PR from the 4xx lib.