Support 16 bit SPI #107
Merged
Support 16 bit SPI #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not too happy about all that code duplication, we can do much better than that. I made you a PR with my suggested way of cleaning this up: zklapow#1 |
|
I merged @ra-kete changes into this branch and brought this up to date with master, should be mergeable or at least ready for review now. |
teskje
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for sixteen bit words in SPI by adding a generic parameter for the wordsize (default to 8 for backwards compatibility). The
FullDuplex<u16>impl is basically just copied with minor edits, there probably a better way to do this but copying seemed fine.Ideally we could merge this alongside #99 and then SPI support would be much more complete!