Implement InputPin GPIO traits #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@manuel-woelker similar to the other PR, do you think it would be good to use the |
manuel-woelker
force-pushed
the
fb-inputpin
branch
from
1d62ace
to
5bc0fbb
Compare
|
Whoops, I thought I remembered the InputPin losing unproven, but alas not yet... I added the unproven feature flag, and added a dependency on "embedded-hal/unproven" |
|
Looks great! Thanks for the PR. |
|
I just tested this out and it works great 😄 so exciting! |
Closed
sirhcel
pushed a commit
to sirhcel/stm32f3xx-hal
that referenced
this pull request
Jun 8, 2021
Give more prominent information on wiring for test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the original pull request by @octycs
cf. japaric/stm32f30x-hal#16
Let me know if you have any feedback