Fix off-by-one error in Delay impl #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Sh3Rm4n, this change works a treat on top of my sirhcel@2a9b8f7. Isn't this something for the next release as well? |
|
Thanks @jamesmunns! This for fixing this bug and keeping this HAL implementation up to date with the other implementations. Only rustfmt is unhappy, so this PR is almost good to go. I can fix this myself, if you don't mind though :) |
This makes two changes: * Updates the MAX_RVR to a 24-bit (not 25-bit) number * Moves tracking variable update for better potential precision This brings the stm32f3 delay impl up to date with the [nrf52 delay impl](https://github.com/nrf-rs/nrf-hal/blob/master/nrf-hal-common/src/delay.rs#L46-L72).
Sh3Rm4n
referenced
this pull request
in sirhcel/stm32f3xx-hal
Jun 16, 2021
This struct could be converted from a Baud value already used in exisiting code and should therefor not break it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes:
This brings the stm32f3 delay impl up to date with the nrf52 delay impl.