Add StatefulOutputPin and ToggleableOutputPin #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: I shamelessly stole the implementation from https://github.com/stm32-rs/stm32f1xx-hal. |
|
This looks great. I'll be looking to get this in once we test out and merge #21 since it has some hefty changes to |
dfrankland
requested changes
Nov 14, 2019
There was a problem hiding this comment.
I was able to test blinking successfully using an example here: dfrankland/proton-c@8b02d2f
Building all device features was successful as well.
Sh3Rm4n
force-pushed
the
stateful
branch
2 times, most recently
from
d5a0f86
to
136e126
Compare
|
Applied change requests. Ready for review again :) |
dfrankland
approved these changes
Nov 14, 2019
|
Nice work 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it on the STM32F303 / STM32DISCOVERY Board, with the method provided in the example.