Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stm32f3 to 0.9 #39

Merged
merged 5 commits into from
Dec 27, 2019
Merged

Update stm32f3 to 0.9 #39

merged 5 commits into from
Dec 27, 2019

Conversation

Sh3Rm4n
Copy link
Member

@Sh3Rm4n Sh3Rm4n commented Dec 16, 2019

This PR updates to stm32f3 v0.9.

Also, register access methods where upgraded to use the variant based methods, introduced in the svd2rust version 16 (see the CHANGELOG).

I reduced the scope to change only the peripherals, where it worked seamless.

I've prepared PR's for the missing peripheral modules, but I did'nt include them, as stm32f3 does not provide the variant methods for all stm32f3 devices, because they are'nt documented yet.

@dfrankland
Copy link
Member

dfrankland commented Dec 22, 2019

I wasn't able to get serial or USB HID to work with this upgrade 😖

Simple things like blinking LEDs, input pins, semihosting, and using alloc all worked.

@Sh3Rm4n
Copy link
Member Author

Sh3Rm4n commented Dec 22, 2019

Okay. I'll have to investigate. Will check this tomorrow.

Thanks for testing it! :)

@Sh3Rm4n
Copy link
Member Author

Sh3Rm4n commented Dec 23, 2019

Okay, i could confirm, that USB is not working.

It seems like, that the clearing of the reset pin is important (sometimes?)

I remove the clear_bit part, because sometimes it says in the reference
manual
, that writing 0 to the reset register "has no effect".

On other occasion it say's "does not reset the " as for USB.

stm32f3 does not expose a unreset variant method.

As the reset register are read-write registers and it worked before, i readded
the clear_bit part

It should work now again.

Copy link
Member

@dfrankland dfrankland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I was able to successfully test everything.

CHANGELOG.md Outdated Show resolved Hide resolved
@dfrankland
Copy link
Member

I think we should be good to go on this one. @Sh3Rm4n feel free to merge 👍

@Sh3Rm4n Sh3Rm4n merged commit 4bbe410 into stm32-rs:master Dec 27, 2019
@Sh3Rm4n Sh3Rm4n deleted the update-stm32f3-2 branch December 27, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants