Fixes for i2c Read #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! 👍 Thanks for this PR. I'll have a closer look later today (i hope) |
|
And an example trace from where read was failing due to an incorrect autoend setting: |
Sh3Rm4n
reviewed
Mar 15, 2020
Sh3Rm4n
requested changes
Mar 15, 2020
|
Thank you for your logic analyzer proves btw :) If you want, you could a a FIX note to the CHANGELOG :) |
|
The CI is currently stuck. I don't know, how to rerun it, but as conflicts have to be resolved anyways, this should retrigger the CI. I hope it will work then :) |
- Use automatic mode for autoend with Read - Update CHANGELOG.md
|
Fixed the merge conflicts and re-squashed the PR |
Sh3Rm4n
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readbusy_waitmacroTested with the following embedded hal i2c drivers: