Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear UART overflow bit. #91

Merged
merged 5 commits into from
Apr 9, 2020
Merged

Clear UART overflow bit. #91

merged 5 commits into from
Apr 9, 2020

Conversation

jonathanpallant
Copy link
Contributor

No description provided.

@jonathanpallant
Copy link
Contributor Author

Permission to use, copy, modify, and/or distribute this bugfix for any purpose with or without fee is hereby granted.

therealprof
therealprof approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably would have used one unsafe deref of the icr but other than that this is really important to have.

@jonathanpallant
Copy link
Contributor Author

I probably would have used one unsafe deref of the icr.

Yeah, good idea. FTFY.

@thejpster thejpster mentioned this pull request Apr 9, 2020
Closed
therealprof
therealprof approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

cc @Sh3Rm4n

strom-und-spiele
strom-und-spiele requested changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@strom-und-spiele strom-und-spiele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have some cosmetic requests but LGTM.

src/serial.rs Outdated Show resolved Hide resolved
src/serial.rs Outdated Show resolved Hide resolved
@Sh3Rm4n Sh3Rm4n merged commit 2057512 into stm32-rs:master Apr 9, 2020
@jonathanpallant jonathanpallant deleted the fix_uart_overflow_sticky branch May 18, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strom-und-spiele strom-und-spiele strom-und-spiele requested changes

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonathanpallant @therealprof @strom-und-spiele @Sh3Rm4n