Allow DMA on both halves of a split Serial<USART> separately. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobmcwhirter
force-pushed
the
dma-split-serial
branch
from
079cdbf
to
c2035ee
Compare
|
@bobmcwhirter Mind rebasing this so we can have a look at the gist of this change? |
|
Will do shortly.
…On Fri, Jul 31, 2020 at 5:46 AM Daniel Egger ***@***.***> wrote:
@bobmcwhirter <https://github.com/bobmcwhirter> Mind rebasing this so we
can have a look at the gist of this change?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#193 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAD4TY3KQLM5DY3JXR5OJ3R6KHH5ANCNFSM4PK3JLKA>
.
|
bobmcwhirter
force-pushed
the
dma-split-serial
branch
from
c2035ee
to
9b44cf7
Compare
|
rebased/repushed. |
|
Hmm, seems like the first commit is undoing one of my last changes. |
|
I probably screwed up my rebase I guess. Will fix Monday.
…On Fri, Jul 31, 2020 at 7:39 PM Thales ***@***.***> wrote:
Hmm, seems like the first commit is undoing one of my last changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#193 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAD4T2GWJ2WWEZPQTQ6QO3R6NIZFANCNFSM4PK3JLKA>
.
|
Provide DmaConfig enum for setting up DMA on the Tx or Rx half of the serial during init.
bobmcwhirter
force-pushed
the
dma-split-serial
branch
from
9b44cf7
to
7d80205
Compare
|
Hopefully this looks better. |
src/serial.rs
Outdated
| .dmat().enabled() | ||
| }) | ||
| } | ||
| _ => {} |
There was a problem hiding this comment.
Maybe this should be DmaConfig::None instead ?
There was a problem hiding this comment.
Ah, good point. I'll modify.
wrt hardware, yes, on an stm32f401re against my USART6.
thalesfragoso
approved these changes
Aug 3, 2020
therealprof
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
Nice. Thanks for the addtion @bobmcwhirter. Thanks for the review @thalesfragoso.
bors r+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based upon and dependent upon #186