Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimized SPI blocking write #523

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

optimized SPI blocking write #523

wants to merge 2 commits into from

Conversation

burrbull
Copy link
Contributor

@burrbull burrbull commented Aug 27, 2022 •
edited

requre testing

@burrbull burrbull marked this pull request as ready for review August 27, 2022 19:49
@burrbull burrbull mentioned this pull request Aug 28, 2022
Merged
bors bot added a commit that referenced this pull request Aug 28, 2022
@bors @burrbull
Merge #524
fa67f41 
524: Spi u16 frame r=therealprof a=burrbull

part of #523 

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@burrbull burrbull force-pushed the spi-opt3 branch 2 times, most recently from 43ae47e to 4992630 Compare August 29, 2022 13:16
@burrbull burrbull changed the title Spi u16 frame size & optimized SPI write optimized SPI blocking write Aug 29, 2022
@burrbull
Copy link
Contributor Author

cc @adamgreig @therealprof

@burrbull burrbull force-pushed the spi-opt3 branch 2 times, most recently from 184ad1b to f7f9abe Compare August 29, 2022 14:41
burrbull
burrbull commented Aug 30, 2022
View reviewed changes
src/spi.rs Outdated
Comment on lines 719 to 720
// Wait for final !BSY
while self.is_busy() {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 1 moment I'm not sure. Do we need to check BSY here?
It takes 3-4 SPI clocks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved busy check to Spi::disable

@burrbull burrbull marked this pull request as draft August 31, 2022 08:53
@burrbull burrbull marked this pull request as ready for review August 16, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@burrbull