Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alt enums #594

Merged
merged 15 commits into from
Apr 14, 2023
Merged

Alt enums #594

merged 15 commits into from
Apr 14, 2023

Conversation

burrbull
Copy link
Contributor

@burrbull burrbull commented Apr 9, 2023

No description provided.

@burrbull burrbull force-pushed the alt-enums branch 4 times, most recently from 7414540 to 38c11e3 Compare April 9, 2023 18:30
@burrbull burrbull marked this pull request as ready for review April 9, 2023 21:16
@burrbull burrbull marked this pull request as draft April 10, 2023 09:56
@burrbull burrbull marked this pull request as ready for review April 10, 2023 13:37
@burrbull
Copy link
Contributor Author

cc @therealprof review please

therealprof
therealprof reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice. Have you done any code size comparisons before/after?

@burrbull
Copy link
Contributor Author

Looks very nice. Have you done any code size comparisons before/after?

approximatelly the same. +-2%

sometimes slightly bigger, simetimes smaller

therealprof
therealprof approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanls for working on this.

bors r+

bors bot added a commit that referenced this pull request Apr 14, 2023
@bors @burrbull
Merge #594
0b8d94b 
594: Alt enums r=therealprof a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 14, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@burrbull
Copy link
Contributor Author

bors retry

bors bot added a commit that referenced this pull request Apr 14, 2023
@bors @burrbull
Merge #594
a81227c 
594: Alt enums r=therealprof a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 14, 2023

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

Response status code: 422
{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@burrbull
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 14, 2023

Build succeeded:

@bors bors bot merged commit 01c6afb into master Apr 14, 2023
@bors bors bot deleted the alt-enums branch April 14, 2023 11:13
@burrbull burrbull mentioned this pull request Jul 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@burrbull @therealprof