Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USART methods to check for error #160

Merged
merged 1 commit into from Nov 3, 2020
Merged

Add USART methods to check for error #160

merged 1 commit into from Nov 3, 2020

Conversation

hannobraun
Copy link
Collaborator

This is useful to handle cases where multiple errors have occurred.
Previously, it wouldn't have been necessary to detect and handle all
those errors, without trying to read again.

@korken89
Copy link
Collaborator

Hi, thanks for the addition!

I gave it a spin where I generated overrun errors, and it seems the bit is not cleared?
Calling the check_for_errors always return Overrun every time.
Do you know what might be causing this?

@korken89
Copy link
Collaborator

Sorry, I tracked it down to my example code that was messed up.

Copy link
Collaborator

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ping @MabezDev

@korken89
Copy link
Collaborator

korken89 commented Nov 2, 2020

Hi @hannobraun, will you rebase this PR?

Copy link
Collaborator

@MathiasKoch MathiasKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Should be good to merge after a rebase

This is useful to handle cases where multiple errors have occurred.
Previously, it wouldn't have been necessary to detect and handle all
those errors, without trying to read again.
@hannobraun
Copy link
Collaborator Author

Rebased. CI is green. Should be good to go now.

@MathiasKoch MathiasKoch merged commit 2638439 into stm32-rs:master Nov 3, 2020
@hannobraun hannobraun deleted the usart-error branch November 4, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants