Skip to content

Add USART methods to check for error#160

Merged
MathiasKoch merged 1 commit into
stm32-rs:masterfrom
braun-embedded:usart-error
Nov 3, 2020
Merged

Add USART methods to check for error#160
MathiasKoch merged 1 commit into
stm32-rs:masterfrom
braun-embedded:usart-error

Conversation

@hannobraun

Copy link
Copy Markdown
Collaborator

This is useful to handle cases where multiple errors have occurred.
Previously, it wouldn't have been necessary to detect and handle all
those errors, without trying to read again.

@korken89

Copy link
Copy Markdown
Collaborator

Hi, thanks for the addition!

I gave it a spin where I generated overrun errors, and it seems the bit is not cleared?
Calling the check_for_errors always return Overrun every time.
Do you know what might be causing this?

@korken89

Copy link
Copy Markdown
Collaborator

Sorry, I tracked it down to my example code that was messed up.

@korken89 korken89 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ping @MabezDev

@korken89

korken89 commented Nov 2, 2020

Copy link
Copy Markdown
Collaborator

Hi @hannobraun, will you rebase this PR?

@MathiasKoch MathiasKoch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Should be good to merge after a rebase

This is useful to handle cases where multiple errors have occurred.
Previously, it wouldn't have been necessary to detect and handle all
those errors, without trying to read again.
@hannobraun

Copy link
Copy Markdown
Collaborator Author

Rebased. CI is green. Should be good to go now.

@MathiasKoch MathiasKoch merged commit 2638439 into stm32-rs:master Nov 3, 2020
@hannobraun hannobraun deleted the usart-error branch November 4, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants