Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to set USBD_PID to 0 (error thrown) #2215

Closed
me21 opened this issue Nov 30, 2023 · 0 comments · Fixed by #2219
Closed

Unable to set USBD_PID to 0 (error thrown) #2215

me21 opened this issue Nov 30, 2023 · 0 comments · Fixed by #2219
Labels
enhancement New feature or request
Projects
STM32 core based on ST HAL
Milestone
2.8.0

Comments

@me21
Copy link

me21 commented Nov 30, 2023 •
edited
Loading

I'd like to use zero PID for my USB device but I'm currently unable to do it as it's forbidden by the following code:

Arduino_Core_STM32/cores/arduino/stm32/usb/usbd_desc.c

Lines 45 to 47 in 08ab454

#if !USBD_VID || !USBD_PID
#error "USB VID or PID not specified"
#endif

According to https://stackoverflow.com/questions/30098394/is-pid-0-a-valid-for-usb-device, PID == 0x0000 is a valid PID, and the accepted answer there contains a link to a list of existing USB products, some of which have zero PID.
@fpistm fpistm added the enhancement New feature or request label Dec 4, 2023
@fpistm fpistm added this to To do in STM32 core based on ST HAL via automation Dec 4, 2023
@fpistm fpistm added this to the 2.8.0 milestone Dec 4, 2023
fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Dec 5, 2023
@fpistm
feat(usb): allow USB PID to be 0x0000
503f12e 
Fixes stm32duino#2215

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm mentioned this issue Dec 5, 2023
Merged
STM32 core based on ST HAL automation moved this from To do to Done Dec 5, 2023
fpistm added a commit that referenced this issue Dec 5, 2023
@fpistm
feat(usb): allow USB PID to be 0x0000
b149a92 
Fixes #2215

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
tadtruex pushed a commit to TadAtThayer/Arduino_Core_STM32 that referenced this issue Apr 23, 2024
@fpistm @tadtruex
feat(usb): allow USB PID to be 0x0000
1633a87 
Fixes stm32duino#2215

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
STM32 core based on ST HAL
  
Done
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

feat(usb): allow USB PID to be 0x0000 fpistm/Arduino_Core_STM32
2 participants
@me21 @fpistm